Detect arguments as well

[samwaseda]

Following the effort in #155, I started trying to parse variables as well. Edits will follow....

[github-actions]

👈 Launch a binder notebook on branch pyiron/flowrep/args

[samwaseda]

@liamhuber I started looking into the possibility of including variables as well. Frankly I'm also not really convinced but I still would like to explore the possibility

[codecov]

Codecov Report

❌ Patch coverage is 68.18182% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.45%. Comparing base (d81e55e) to head (c1c7978).

Files with missing lines	Patch %	Lines
flowrep/models/parsers/dependency_parser.py	64.55%	28 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           crawler     #164      +/-   ##
===========================================
- Coverage    98.97%   97.45%   -1.52%     
===========================================
  Files           28       28              
  Lines         1942     2007      +65     
===========================================
+ Hits          1922     1956      +34     
- Misses          20       51      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[samwaseda]

I just had a discussion with @XzzX and we think we can keep the current implementation is maybe not quite as useless as I had imagined, because with this implementation it is now possible to throw an error as soon as an external variable is used.

[liamhuber]

because with this implementation it is now possible to throw an error as soon as an external variable is used.

Failing cleanly is infinitely better than looking like everything is well-provenanced when it isn't. However, I still think that restricting "ok locally defined stuff" to mean "don't use any symbols outside your function definition" is going to turn out to be a more annoying, more restrictive, more-work solution than telling people "you'll have to use well-versioned code to contribute to the KG". As an intermediate step towards catching and leveraging these external symbols, this still seems like solid progress though.