Merged
Conversation
To not fake parsing version info, since the validation is now delayed until the parsing is finished. To reach the validation errors, we need to test things that actually parse! Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
|
|
Through to children as we walk the state. Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
liamhuber
force-pushed
the
propagate-constraints
branch
from
2414536 to
05797df
Compare
To reduce the number of arguments we're passing around to create fresh body walkers Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Streamline away the other protocols by putting a `fork` method right on the walker Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
So the walker comes first. This makes the parsers look more like methods of `WorkflowParser`, which they rightly are, we're just breaking them out (and introducing a protocol to do it) to keep the files better focused Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
To be narrower and more demanding. YAGNI. Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
To better align protocol and implementation order of appearance (the implementation `visit` is inherited, but now the `visit_*` methods appear in the "right" spot Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
For similarity with other fork Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Streamline protocol
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 98.94% 98.95%
=======================================
Files 27 27
Lines 1898 1908 +10
=======================================
+ Hits 1878 1888 +10
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While constraints were there to demand that workflows or atomic nodes had versions, or weren't in
__main__, or weren't<locals>, these were not actually passed down to the on-the-fly parsing of atomic nodes encountered during the workflow parsing. Now they are.Needs pyiron/pyiron_snippets#77 though, and I'm not 100% convinced of the
VersionConstraintsvs introducing some sort of parser class, so I'm going to leave this as a draft. The propagation is key to proper version info validation, but the actual call signatures might change a bit here.Update: Ok, so I force pushed over the last bit now it depends on pyiron/pyiron_snippets#78 instead, but this is a net simplification. Overall I think this simplified the code a little by grouping the parsing state into a single argument to pass around, and squashes (and now tests for) the critical bug of passing the version parsing state deeply into child nodes.