[Fix] Accept benchmarks when block_allocation is faster than the processpoolexecutor#917
[Fix] Accept benchmarks when block_allocation is faster than the processpoolexecutor#917jan-janssen merged 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request modifies a test assertion in the benchmark test suite. The change updates a timing validation to accept either "process" or "block_allocation" as the minimum timing entry, making the test expectation more flexible while preserving all other assertions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 38 38
Lines 1937 1937
=======================================
Hits 1816 1816
Misses 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It's not a bug it is just a fix to improve the continuous integration stability.
Summary by CodeRabbit