Skip to content

Fix version numbers for integration tests#844

Merged
jan-janssen merged 2 commits intomainfrom
mpi4py
Oct 15, 2025
Merged

Fix version numbers for integration tests#844
jan-janssen merged 2 commits intomainfrom
mpi4py

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Oct 15, 2025

Summary by CodeRabbit

  • Chores
    • Pinned key dependencies in integration and Binder environments to ensure consistent installations and reproducible builds.
    • Improves CI stability, environment reliability, and reduces unexpected breakages during setup.
    • Enhances Binder launch consistency for demos and notebooks.
    • No user-facing functionality changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Pins were added to dependency versions in two environment configuration files. .ci_support/environment-integration.yml now fixes h5py to 3.14.0, mpi4py to 4.1.1, and numpy to 2.3.3. binder/environment.yml now pins numpy to 2.3.3. No code, API, or control-flow changes.

Changes

Cohort / File(s) Summary
CI integration env pins
.ci_support/environment-integration.yml
Pinned h5py=3.14.0, mpi4py=4.1.1, numpy=2.3.3 (replacing previously unpinned entries).
Binder env pin
binder/environment.yml
Pinned numpy=2.3.3 (replacing previously unpinned entry).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • h5py - 3.13.0 #593 — Also adjusts h5py version pins in environment configs; similar change targeting different files/versions.

Poem

I nibble on versions, crisp and clean,
Pinning my carrots to 2.3.3 green. 🥕
h5py’s snug, mpi4py tight,
Environments stable, day and night.
Hippity-hop through YAML I roam—
Locked dependencies, a happy home!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of pinning dependency versions for the integration test environment by fixing version numbers, matching the updates made to the CI and binder configurations. It is concise, specific, and clearly conveys the intent of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mpi4py

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9b6364 and 993803a.

📒 Files selected for processing (2)
  • .ci_support/environment-integration.yml (1 hunks)
  • binder/environment.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: unittest_mpich (ubuntu-22.04-arm, 3.13)
  • GitHub Check: unittest_mpich (ubuntu-24.04-arm, 3.13)
  • GitHub Check: unittest_win
  • GitHub Check: unittest_mpich (macos-latest, 3.13)
  • GitHub Check: unittest_openmpi (ubuntu-22.04-arm, 3.13)
  • GitHub Check: unittest_openmpi (macos-latest, 3.13)
  • GitHub Check: unittest_openmpi (ubuntu-24.04-arm, 3.13)
  • GitHub Check: unittest_slurm_mpich
  • GitHub Check: unittest_old
  • GitHub Check: unittest_flux_openmpi
  • GitHub Check: unittest_flux_mpich
  • GitHub Check: notebooks_integration
  • GitHub Check: notebooks
  • GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
  • GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
🔇 Additional comments (2)
binder/environment.yml (1)

5-5: numpy 2.3.3 is published on conda-forge: the pinned version exists and Binder will resolve the environment successfully.

.ci_support/environment-integration.yml (1)

4-7: Pinned versions confirmed on conda-forge. h5py 3.14.0, mpi4py 4.1.1, and numpy 2.3.3 are available; CI installation should succeed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.16%. Comparing base (e891eec) to head (993803a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          34       34           
  Lines        1688     1688           
=======================================
  Hits         1657     1657           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 5b25827 into main Oct 15, 2025
62 of 63 checks passed
@jan-janssen jan-janssen deleted the mpi4py branch October 15, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant