-
Notifications
You must be signed in to change notification settings - Fork 4
Clean up: warn when functionality is not available #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3b7f782
Clean up: warn when functionality is not available
jan-janssen bd1830a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f98eb1b
Move import into function
jan-janssen 62793be
Merge remote-tracking branch 'origin/import-error' into import-error
jan-janssen f4d4172
refactor
jan-janssen 0f8975e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3d998d6
fix minimal test
jan-janssen c5ef8ad
fix import
jan-janssen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import os | ||
|
||
import cloudpickle | ||
import numpy as np | ||
|
||
group_dict = { | ||
"fn": "function", | ||
"args": "input_args", | ||
"kwargs": "input_kwargs", | ||
"output": "output", | ||
"error": "error", | ||
"runtime": "runtime", | ||
"queue_id": "queue_id", | ||
} | ||
|
||
|
||
def get_cache_data(cache_directory: str) -> list[dict]: | ||
""" | ||
Collect all HDF5 files in the cache directory | ||
|
||
Args: | ||
cache_directory (str): The directory to store cache files. | ||
|
||
Returns: | ||
list[dict]: List of dictionaries each representing on of the HDF5 files in the cache directory. | ||
""" | ||
import h5py | ||
|
||
file_lst = [] | ||
for task_key in os.listdir(cache_directory): | ||
file_name = os.path.join(cache_directory, task_key, "cache.h5out") | ||
os.makedirs(os.path.join(cache_directory, task_key), exist_ok=True) | ||
if os.path.exists(file_name): | ||
with h5py.File(file_name, "r") as hdf: | ||
file_content_dict = { | ||
key: cloudpickle.loads(np.void(hdf["/" + key])) | ||
for key in group_dict.values() | ||
if key in hdf | ||
} | ||
file_content_dict["filename"] = file_name | ||
file_lst.append(file_content_dict) | ||
return file_lst | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Missing error handling for file operations.
The function doesn't include error handling for scenarios like corrupted HDF5 files, permission issues, or other I/O errors that might occur when reading files.
Consider adding try-except blocks to handle potential exceptions:
📝 Committable suggestion