hooks: remove hook for google.api #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hook for `google.api`, which erroneously assumes that presence of the `google.api` namespace package implies availability of the `google-api-core` dist. This results in an error when, for example, only `googleapis-common-protos` is installed in the build environment. The collection of `google-api-core` metadata should be sufficiently handled by the hook for `google.api_core`.
bwoodsend
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hook for
google.api, which erroneously assumes that presence of thegoogle.apinamespace package implies availability of thegoogle-api-coredist.This results in an error when, for example, only
googleapis-common-protosis installed in the build environment.The collection of
google-api-coremetadata should be sufficiently handled by the hook forgoogle.api_core.See https://github.com/orgs/pyinstaller/discussions/8206