facts.server.Port: fix ss command for Alpine/BusyBox compatibility#1586
Open
wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
Open
facts.server.Port: fix ss command for Alpine/BusyBox compatibility#1586wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
Conversation
BusyBox ss (used on Alpine) does not support the -H flag or filter expressions like 'src :port'. Replace with pipe to grep which works on both iproute2 and BusyBox ss. Append || true so grep returning no matches does not cause a command failure.
On Alpine, netstat outputs program names like "sshd [listener" which contain spaces. The parser was taking the last whitespace-delimited field, missing the PID/program column. Now scans fields for the one containing "/" to reliably find the PID/program pair.
wowi42
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BusyBox ss (used sometimes on Alpine) does not support the -H flag or filter expressions like 'src :port'. Replace with pipe to grep which works on both iproute2 and BusyBox ss. Append || true so grep returning no matches does not cause a command failure.
On Alpine, netstat outputs program names like "sshd [listener" which contain spaces. The parser was taking the last whitespace-delimited field, missing the PID/program column. Now scans fields for the one containing "/" to reliably find the PID/program pair.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)