Skip to content

facts.server.SecurityLimits: handle missing limits.conf #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wowi42 wants to merge 1 commit into
base: 3.x
Choose a base branch
from
+2 −2
Open

facts.server.SecurityLimits: handle missing limits.conf #1582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyinfra/facts/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ class SecurityLimits(FactBase):

@override
def command(self):
return "cat /etc/security/limits.conf"
return "cat /etc/security/limits.conf 2>/dev/null || true"
Copy link
Member

@Fizzadar Fizzadar Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "cat /etc/security/limits.conf 2>/dev/null || true"
return "! test -e /etc/security/limits.conf || cat /etc/security/limits.conf"

This way we still catch errors calling cat which the || true method silently ignores.


default = list

Expand Down
2 changes: 1 addition & 1 deletion tests/facts/server.SecurityLimits/security_limits.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"command": "cat /etc/security/limits.conf",
"command": "cat /etc/security/limits.conf 2>/dev/null || true",
"output": [
"# <domain> <type> <item> <value>",
"#* soft core ",
Expand Down