facts: fix requires_command shell operator precedence with compound commands#1579
Open
wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
Open
facts: fix requires_command shell operator precedence with compound commands#1579wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
Conversation
…ommands When a fact uses `requires_command` and its command contains `&&` chains (e.g. runit.RunitStatus), the generated shell command has incorrect operator precedence: ! command -v sv >/dev/null || export SVDIR=... && cd "$SVDIR" && ... Shell parses `||` and `&&` left-to-right, so when `sv` is missing the `||` short-circuits but subsequent `&&` clauses still run and fail, causing the fact to error instead of returning the default value. Wrap the fact command in a subshell so `||` applies to the entire chain: ! command -v sv >/dev/null || ( export SVDIR=... && cd "$SVDIR" && ... )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fact uses
requires_commandand its command contains&&chains (e.g. runit.RunitStatus), the generated shell command has incorrect operator precedence:! command -v sv >/dev/null || export SVDIR=... && cd "$SVDIR" && ...
Shell parses
||and&&left-to-right, so whensvis missing the||short-circuits but subsequent&&clauses still run and fail, causing the fact to error instead of returning the default value.Wrap the fact command in a subshell so
||applies to the entire chain:! command -v sv >/dev/null || ( export SVDIR=... && cd "$SVDIR" && ... )
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)