Fix inline comments not stripped from SSH config values#1574
Open
wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
Open
Fix inline comments not stripped from SSH config values#1574wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
wowi42 wants to merge 2 commits intopyinfra-dev:3.xfrom
Conversation
SSH config lines with inline comments (e.g. "IdentityFile ~/.ssh/key # comment") were passed through to paramiko with the comment included, causing issues like "No such file or directory: '/home/user/.ssh/key # comment'". Fixes pyinfra-dev#1568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH config lines with inline comments (e.g. "IdentityFile ~/.ssh/key # comment") were passed through to paramiko with the comment included, causing issues like "No such file or directory: '/home/user/.ssh/key # comment'".
Fixes #1568
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)