Convert API to snake_case #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to prepare PR's in python-shader and visvis2 to adjust to the new API. Then I'll merge them in quick succession. |
Korijn
reviewed
Feb 12, 2020
|
|
||
| def getSizeAndPixelRatio(self): | ||
| def get_size_and_pixel_ratio(self): |
There was a problem hiding this comment.
do you think perhaps the entire Qt widget should have Qt style conventions? eh, it's just a little straining on the eyes :) wouldn't mind merging this as is
There was a problem hiding this comment.
mmm, that's a good question. I think that since the methods that we add here are part of the wgpu API (they come from an abstract base class), they should be snake_case. It actually makes it clear with what API you're interacting with. But yeah, it does not look qt-ish :/
almarklein
commented
Feb 12, 2020
Comment on lines
+75
to
86
| render_pipeline = device.create_render_pipeline( | ||
| layout=pipeline_layout, | ||
| vertexStage={"module": vshader, "entryPoint": "main"}, | ||
| fragmentStage={"module": fshader, "entryPoint": "main"}, | ||
| primitiveTopology=wgpu.PrimitiveTopology.triangle_list, | ||
| rasterizationState={ | ||
| "frontFace": wgpu.FrontFace.ccw, | ||
| "cullMode": wgpu.CullMode.none, | ||
| "depthBias": 0, | ||
| "depthBiasSlopeScale": 0.0, | ||
| "depthBiasClamp": 0.0, | ||
| vertex_stage={"module": vshader, "entry_point": "main"}, | ||
| fragment_stage={"module": fshader, "entry_point": "main"}, | ||
| primitive_topology=wgpu.PrimitiveTopology.triangle_list, | ||
| rasterization_state={ | ||
| "front_face": wgpu.FrontFace.ccw, | ||
| "cull_mode": wgpu.CullMode.none, | ||
| "depth_bias": 0, | ||
| "depth_bias_slope_scale": 0.0, | ||
| "depth_bias_clamp": 0.0, | ||
| }, |
There was a problem hiding this comment.
Perhaps this illustrates the changes best:
- the function name is snake_case
- the direct arguments are snake_case
- the "sub-arguments" (keys of args that are dicts) are snake_case
- enums and flags are unchanged.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57