Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, improve, and rerun codegen script #30

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Fix, improve, and rerun codegen script #30

merged 3 commits into from
Jan 10, 2020

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Jan 10, 2020

  • Remove noqa stuff from the classes that get code injected, because it prevents formatting signatures on a single line, which we need to parse the signatures.
  • Add a fix for black still formatting long sigs on 3 lines even with huge line length.
  • Black also add a comma at the end (previously it did not for this code?)
  • The codegen script now also produces a report.

@@ -1,4 +1,4 @@
[flake8]
max_line_length = 88
extend-ignore = E203
extend-ignore = E203, E501, F821
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adding long lines (E501) here (is enforced by black anyway).
  • Adding undefined type annotations (F821) here until we fix these.

@almarklein almarklein merged commit 51f57cb into master Jan 10, 2020
@almarklein almarklein deleted the dev branch January 10, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant