-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake8 #19
Flake8 #19
Conversation
… root entries as well
It does not load the binary :) Also, the files it generates are blackified before writing, so I'm curious what noqa's were needed. Will have a proper look at this PR after xmas :) |
Really! Doh. I should have just tried it.
Black doesn't fix comments that exceed max line length, for example. Also, the undefined type hints. |
Maybe we should simply disable line length checking on flake8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would be ok with disabling that check! |
Partly addresses #12
Note: I can't run the codegen-script since I don't have a binary yet. I tried adjusting it to produce noqa comments but I can't verify if it works properly. It probably fails to do so because it is used in conjunction with black, so we can't tell on which lines the violations will end up
Either way, this PR:
# noqa
that didn't trigger violationsI'm unsure of the following changes:
Is that how it's supposed to be done?