Skip to content

Allow unparented WxRenderWidget #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Allow unparented WxRenderWidget #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
368ed06
Warn for inproper use of WxRenderWidget
almarklein May 22, 2025
c35bd6e
allow parentless wx window, but dont size it on init
almarklein May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rendercanvas/wx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,13 @@ def _rc_set_logical_size(self, width, height):
parent = self.Parent
if isinstance(parent, WxRenderCanvas):
parent.SetSize(width, height)
else:
elif parent is not None:
self.SetSize(width, height)
else:
# The widget has no parent, likely because its going to inserted in a GUI later.
# This method is likely called from _final_canvas_init and if we call self.SetSize() it will likely error/segfault.
# See https://github.com/pygfx/rendercanvas/issues/91
pass

def _rc_close(self):
self._is_closed = True
Expand Down