Conversation
geoval/core/data.py
Outdated
| mask=(np.isnan(clim) | (n < nmin) | | ||
| np.logical_not( | ||
| (np.logical_not(self.data.mask)). | ||
| mean(axis=0)))) |
There was a problem hiding this comment.
E126 continuation line over-indented for hanging indent
bulli92
left a comment
bulli92
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Can you please
a) take care of the stickler-bot message and correct the line mentioned
b) what I am missing is a unittest, testing the routine. Please implement one and then redo the PR
geoval/core/data.py
Outdated
| #~ for i in xrange(n): | ||
| #~ try: | ||
| #~ yy = stats.mstats.linregress(x, dat[:, i]) | ||
| #~ try: |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ try: | ||
| #~ yy = stats.mstats.linregress(x, dat[:, i]) | ||
| #~ try: | ||
| #~ yy = stats.mstats.linregress(x, dat[:, i]) |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ print x | ||
| #~ print dat[:,i] | ||
| #~ stop | ||
| #res[i] = stats.mstats.linregress(x, dat[:, i]) |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ print dat[:,i] | ||
| #~ stop | ||
| #res[i] = stats.mstats.linregress(x, dat[:, i]) | ||
| #~ except: |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ stop | ||
| #res[i] = stats.mstats.linregress(x, dat[:, i]) | ||
| #~ except: | ||
| #~ print x |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #res[i] = stats.mstats.linregress(x, dat[:, i]) | ||
| #~ except: | ||
| #~ print x | ||
| #~ print dat[:,i] |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ except: | ||
| #~ print x | ||
| #~ print dat[:,i] | ||
| #~ stop |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ for i in xrange(len(self.time)): | ||
| #~ Y,M,D,h,m,s = self._split_time_float(self.time[i]) | ||
| #~ newdate.append(basedate + relativedelta.relativedelta(years=Y,months=M,days=D,hours=h,minutes=m,seconds=s)) | ||
| #~ Y,M,D,h,m,s = self._split_time_float(self.time[i]) |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ Y,M,D,h,m,s = self._split_time_float(self.time[i]) | ||
| #~ newdate.append(basedate + relativedelta.relativedelta(years=Y,months=M,days=D,hours=h,minutes=m,seconds=s)) | ||
| #~ Y,M,D,h,m,s = self._split_time_float(self.time[i]) | ||
| #~ newdate.append(basedate + relativedelta.relativedelta(years=Y,months=M,days=D,hours=h,minutes=m,seconds=s)) |
There was a problem hiding this comment.
E265 block comment should start with '# '
geoval/core/data.py
Outdated
| #~ ---------- | ||
| #~ t : float | ||
| #~ scalar time indicator | ||
| #~ scalar time indicator |
There was a problem hiding this comment.
E265 block comment should start with '# '
| information on areas from a classic ESRI shapefile | ||
| """ | ||
| assert isinstance(shape,shp.Reader) | ||
| assert isinstance(shape, shp.Reader) |
| """ | ||
| assert isinstance(shape,shp.Reader) | ||
|
|
||
| assert isinstance(shape, shp.Reader) |
|
3 participants
Added get_climatology_stdev() as discrete method to also extract standard deviation in climatological values.