Skip to content

Conversation

@Starbuck5 Starbuck5 requested a review from a team as a code owner September 10, 2025 07:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

📝 Walkthrough

Walkthrough

Version bumps for SDL assets across Windows prebuilt downloads, manylinux SDL2 build script, and Meson config. Paths, filenames, URLs, and checksums were updated to SDL2 2.32.10 and SDL3 3.2.22; related extraction/copy directory names adjusted. No control-flow or API changes.

Changes

Cohort / File(s) Summary of Changes
Windows prebuilt SDL asset updates
buildconfig/download_win_prebuilt.py, meson.build
Updated SDL2 from 2.32.8 to 2.32.10 and SDL3 from 3.2.18 to 3.2.22. Adjusted download URLs, SHA1s, and extraction/target directory names used in Windows builds and Meson’s computed prebuilt directories.
Manylinux SDL2 build script
buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh
Bumped SDL2 version variable from 2.32.8 to 2.32.10; corresponding tarball name, URL, and extraction dir updated; script logic unchanged.
Checksum updates
buildconfig/manylinux-build/docker_base/sdl_libs/sdl2.sha512
Replaced SDL2-2.32.8.tar.gz entry with SDL2-2.32.10.tar.gz and its new SHA-512. Other entries unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

sdl3

Suggested reviewers

  • ankith26

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change in the pull request, namely updating SDL to versions 2.32.10 and 3.2.22, allowing a reader to immediately understand the core update being made.
Description Check ✅ Passed The description includes links to the SDL release tags corresponding to the versions being updated in the pull request, directly relating to the changes made to bump SDL to 2.32.10 and 3.2.22.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch starbuck-SDL-2.32.10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c0b27e and 5fd18ca.

📒 Files selected for processing (4)
  • buildconfig/download_win_prebuilt.py (2 hunks)
  • buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh (1 hunks)
  • buildconfig/manylinux-build/docker_base/sdl_libs/sdl2.sha512 (1 hunks)
  • meson.build (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Starbuck5
PR: pygame-community/pygame-ce#3573
File: src_c/_camera.c:129-131
Timestamp: 2025-08-30T21:11:00.240Z
Learning: When doing SDL2 to SDL3 compatibility changes, Starbuck5 prefers to maintain exact existing behaviors even when other improvements could be made, focusing solely on the compatibility aspect rather than mixing in behavioral fixes.
🪛 Flake8 (7.2.0)
buildconfig/download_win_prebuilt.py

[error] 81-81: continuation line missing indentation or outdented

(E122)


[error] 82-82: continuation line missing indentation or outdented

(E122)


[error] 85-85: continuation line missing indentation or outdented

(E122)


[error] 86-86: continuation line missing indentation or outdented

(E122)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: build (ubuntu-22.04)
  • GitHub Check: Debian (Bookworm - 12) [armv6]
  • GitHub Check: Debian (Bookworm - 12) [s390x]
  • GitHub Check: Debian (Bookworm - 12) [armv7]
  • GitHub Check: Debian (Bookworm - 12) [ppc64le]
  • GitHub Check: build (ubuntu-24.04)
  • GitHub Check: dev-check
  • GitHub Check: debug_coverage (ubuntu-24.04, 3.14.0rc1)
  • GitHub Check: debug_coverage (ubuntu-24.04, 3.9.23)
  • GitHub Check: debug_coverage (ubuntu-24.04, 3.13.5)
  • GitHub Check: x86_64 deps
  • GitHub Check: arm64 deps
  • GitHub Check: x86_64
  • GitHub Check: aarch64
  • GitHub Check: i686
  • GitHub Check: x86
  • GitHub Check: AMD64
  • GitHub Check: msys2 (mingw64, x86_64)
  • GitHub Check: msys2 (clang64, clang-x86_64)
  • GitHub Check: msys2 (ucrt64, ucrt-x86_64)
🔇 Additional comments (4)
buildconfig/manylinux-build/docker_base/sdl_libs/sdl2.sha512 (1)

1-1: Manual checksum verification required
The sandbox environment lacks the necessary tooling (sha512sum/openssl), so automated hash checks failed. Please run the provided shell script locally—on a machine with sha512sum or openssl installed—to confirm the SDL2-2.32.10.tar.gz SHA-512 and the Windows prebuilts’ SHA-1 checksums.

buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh (1)

6-6: LGTM: SDL2_VER bumped to 2.32.10.

Matches the updated checksum entry and URL pattern. No other build logic changes.

buildconfig/download_win_prebuilt.py (1)

272-289: LGTM: updated copy paths match the new prebuilt roots.

The paths align with the unzipped directories “SDL2-devel-2.32.10-VC/SDL2-2.32.10” and “SDL3-devel-3.2.22-VC/SDL3-3.2.22”.

meson.build (1)

97-101: LGTM: version selection updated for SDL2/SDL3 on Windows x86.

sdl_ver now selects 3.2.22 (SDL3) and 2.32.10 (SDL2); other component versions unchanged and remain consistent with prebuilts.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@ankith26 ankith26 added this to the 2.5.6 milestone Sep 10, 2025
@ankith26 ankith26 merged commit ee9c8a9 into main Sep 10, 2025
28 checks passed
@ankith26 ankith26 deleted the starbuck-SDL-2.32.10 branch September 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants