Remove unused code in mask/alphablit #3508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mask module C API is undocumented and unused within pygame-ce. Also removes two strange extern declarations in alphablit.c for functions that are not referenced in the codebase.
Starbuck5
added
the
Code quality/robustness
MightyJosip
approved these changes
Jun 17, 2025
Member
MightyJosip
left a comment
MightyJosip
left a comment
There was a problem hiding this comment.
Yea it is good, I would do some more clearing, like remove both headers atm, and then later reorganize the code after we have everything split up (also when we decide how we should organize everything, so entire codebase is unified, right now that mask.h is completely different to the rest of the code base. I would also move pgMaskObject from pygame_mask. to pygame.h like all the other objects.
But there are no problems with this commit so 👍
ankith26
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mask module C API is undocumented and unused within pygame-ce. Also removes two strange extern declarations in alphablit.c for functions that are not referenced in the codebase.