Skip to content

Elaborate on Vector conversion to tuples/lists #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Elaborate on Vector conversion to tuples/lists #3447

merged 2 commits into from
May 30, 2025

Conversation

@DickerDackel
Copy link
Contributor

@DickerDackel DickerDackel commented May 28, 2025

Attempt at solving issue #3423 - "Update vector doc to have a brief mention of how to convert to lists or tuples"

@DickerDackel DickerDackel requested a review from a team as a code owner May 28, 2025 12:18
@damusss damusss added the docs label May 28, 2025
@damusss damusss linked an issue May 28, 2025 that may be closed by this pull request
Update vector doc to have a brief mention of how to convert to lists or tuples #3423
Closed
oddbookworm
oddbookworm reviewed May 29, 2025
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🥳
I just have one minor nitpick about it. As I mentioned in the contributing channel in the PGC discord server, I don't think this pull is mutually exclusive of #3446, I think it's quite possible for both pulls to merge (although there is a merge conflict in line 38, in which I think this pull's version should win out because it does actually add more detail as opposed to just swapping the order of the words "slices" and "swizzling", which I think are actually in the correct grammatical order here, but I don't really care about that lol)

oddbookworm
oddbookworm reviewed May 29, 2025
View reviewed changes
@AntonisDevStuff AntonisDevStuff mentioned this pull request May 29, 2025
Merged
oddbookworm
oddbookworm approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🎉

damusss
damusss approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarifies it a lot, thanks (I had never thought about the Vector2/tuple nature of swizzling myself even if it could be deduced)

@damusss damusss added this to the 2.5.5 milestone May 30, 2025
@damusss damusss merged commit 388496f into pygame-community:main May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oddbookworm oddbookworm oddbookworm approved these changes

@damusss damusss damusss approved these changes

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

2.5.5

Development

Successfully merging this pull request may close these issues.

Update vector doc to have a brief mention of how to convert to lists or tuples

3 participants

@DickerDackel @oddbookworm @damusss