Port display.c to SDL3
#3428
Open
Port display.c to SDL3
#3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-display-sdl3
branch
from
f16cc05 to
64ba90d
Compare
ankith26
force-pushed
the
ankith26-display-sdl3
branch
2 times, most recently
from
9736da2 to
7006314
Compare
ankith26
force-pushed
the
ankith26-display-sdl3
branch
from
7006314 to
6b66f16
Compare
|
This PR should be done from my side. Given that this is a kinda big PR to review, I have already organized everything into commits that take up stuff one at a time and focus on it fully. So, if it helps reviewing I can split this up into multiple PRs each with subsets of commits from here. |
damusss
reviewed
May 18, 2025
| @@ -331,6 +331,10 @@ pg_window_set_fullscreen(SDL_Window *window, int desktop) | |||
| goto end; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Basically while working on fullscreen changes in display I saw that SDL_SetWindowFullscreenMode in SDL3 has effect only if the window is already in fullscreen mode according to the docs. So I added a call here as well that does that first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to port
display.cto SDL3