Skip to content

Fix unicode property when keyup blocked #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Mar 1, 2025

fixes #1609

my take on the PR #3356 by andrew, which takes that approach and also extends it (with some extra redundancy thrown in just to be sure)

@ankith26 ankith26 requested a review from a team as a code owner March 1, 2025 05:35
@ankith26 ankith26 force-pushed the ankith26-fix-event-keydown branch from 0b3fab7 to 78056a3 Compare March 1, 2025 05:40
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem fine to me, thanks for the more robust version

@oddbookworm oddbookworm added the event pygame.event label Mar 2, 2025
@ankith26 ankith26 force-pushed the ankith26-fix-event-keydown branch from 78056a3 to 004f4f1 Compare March 3, 2025 06:28
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this seems like it would be impossible to unit test, but I can confirm from local testing that this PR fixes the original issue.

@MyreMylar MyreMylar merged commit 57c3222 into main Mar 3, 2025
27 checks passed
@ankith26 ankith26 deleted the ankith26-fix-event-keydown branch March 4, 2025 04:13
@ankith26 ankith26 added this to the 2.5.4 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event pygame.event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEYDOWN events do only return "unicode" property for some keys (3229)
3 participants