Freetype typing fixes, enhancements to dict/tuple/ellipsis typing #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunline
added
type hints
damusss
approved these changes
Jan 25, 2025
Member
damusss
left a comment
damusss
left a comment
There was a problem hiding this comment.
Actually great typehint enhancements, Nice :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of minor general typing fixes and enhancements
TypedDictwhere possible. This will convey more typing info to users.tupleusage with type infotextalso acceptNonevalues, so fixed that. Alsoset_default_resolutioncan be called without arguments (in which case it takes the value 0)