Skip to content

Fix window docs #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fix window docs #3205

merged 1 commit into from
Nov 2, 2024

Conversation

Starbuck5
Copy link
Member

After #3194 it looks like
image

This fixes that. Had to read the docs on the docs system to figure out how to end a inline markup without a space.

@Starbuck5 Starbuck5 added docs window pygame.Window labels Nov 2, 2024
@Starbuck5 Starbuck5 requested a review from a team as a code owner November 2, 2024 08:15
ankith26
ankith26 approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this time I actually tested the docs locally and it works as expected. Thanks! 🥳

oddbookworm
oddbookworm approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel responsible for this one because I suggested using the inline markup here on the PR that introduced this... oops lol

LGTM

@oddbookworm oddbookworm added this to the 2.5.3 milestone Nov 2, 2024
@oddbookworm oddbookworm merged commit b805e0f into pygame-community:main Nov 2, 2024
3 checks passed
@gavinmorrow gavinmorrow mentioned this pull request Nov 2, 2024
Merged
@Starbuck5 Starbuck5 deleted the fix-window-docs branch November 2, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
docs window pygame.Window
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @ankith26 @oddbookworm