Skip to content

Conversation

@zoldalma999
Copy link
Member

No description provided.

@zoldalma999 zoldalma999 requested a review from a team as a code owner October 6, 2024 09:48
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@damusss damusss added bugfix PR that fixes bug typing pygame.typing labels Oct 6, 2024
@ankith26 ankith26 added this to the 2.5.2 milestone Oct 6, 2024
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM 👍

@ankith26 ankith26 merged commit 16a8fd0 into pygame-community:main Oct 6, 2024
@zoldalma999 zoldalma999 deleted the misc-fixes branch October 6, 2024 10:41
@aatle
Copy link
Member

aatle commented Oct 6, 2024

Note: (despite the 3 approving reviews and the passed checks,) the TypeAlias additions are actually problematic because it is unavailable for python <3.10.
See #3149 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes bug typing pygame.typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants