Added additional circle attributes #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added circle attributes - circle.top - circle.bottom - circle.left - circle.right Co-Authored-By: Alberto <103119829+itzpr3d4t0r@users.noreply.github.com>
itzpr3d4t0r
reviewed
Sep 28, 2024
itzpr3d4t0r
reviewed
Sep 28, 2024
itzpr3d4t0r
reviewed
Sep 28, 2024
Contributor
|
try to setup pre-commit @MrRedstone058 so you can say NO to linting problems (especially for workflows) : https://github.com/pygame-community/pygame-ce/wiki/Opening-a-pull-request |
itzpr3d4t0r
added
New API
itzpr3d4t0r
reviewed
Sep 29, 2024
itzpr3d4t0r
reviewed
Sep 29, 2024
itzpr3d4t0r
approved these changes
Sep 29, 2024
Member
itzpr3d4t0r
left a comment
itzpr3d4t0r
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing!!
damusss
approved these changes
Sep 29, 2024
Member
damusss
left a comment
damusss
left a comment
There was a problem hiding this comment.
LGTMT! Thanks for helping porting geometry features! 😄
MyreMylar
approved these changes
Oct 1, 2024
Member
MyreMylar
left a comment
MyreMylar
left a comment
There was a problem hiding this comment.
OK, all looks good to me 👍
Tested it locally running the new tests and in my own circle test program. Does what it says and code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added circle attributes
Credits
Geometry Project:
For code, docs and tests:
@novialriptide @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar @Matiiss @newpaxonian @maqa41 @blankRiot96
Also thanks to @Starbuck5 for kickstarting the idea and the occasional help!
Functionality added in this PR
circle.chttps://github.com/pygame-community/pygame-geometry/blame/main/src_c/circle.c
Credits to @Emc2356 @itzpr3d4t0r @novialriptide
geometry.pyihttps://github.com/pygame-community/pygame-geometry/blame/main/geometry.pyi
Credits to @Emc2356 @itzpr3d4t0r @novialriptide @ScriptLineStudios @avaxar
geometry_test.pyhttps://github.com/pygame-community/pygame-geometry/blame/main/test/test_circle.py
Credits to @itzpr3d4t0r @novialriptide
geometry.rsthttps://github.com/pygame-community/pygame-geometry/blame/main/docs/circle.rst
Credits to @itzpr3d4t0r
geometry.hhttps://github.com/pygame-community/pygame-geometry/blame/main/src_c/include/geometry.h
Credits to @Emc2356 @itzpr3d4t0r @maqa41