Bump ubuntu to 24.04 on CI, fix cppcheck #3123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-ci-ubuntu-upgrade
branch
from
5f33e92 to
ff739cc
Compare
damusss
added
Code quality/robustness
Starbuck5
reviewed
Sep 27, 2024
ankith26
force-pushed
the
ankith26-ci-ubuntu-upgrade
branch
from
ff739cc to
14f4535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 has been declared as generally available on github actions. At the same time, Ubuntu 20.04 is being phased out and will be removed soon.
This PR makes a couple of changes to accommodate for 24.04 in our code. Most notably, the
cppcheckversion change has made me do a couple of changes to the test command as well as the code in one instance (the new version did not like something incolor.c)This PR is also a prerequisite for dropping Python 3.8 support because Ubuntu 20.04 is on Python 3.8