Skip to content

Conversation

@MrValdez
Copy link
Contributor

I've noticed that the new Window API have different behavior with events. I've updated the documentation to reflect this.

@MrValdez MrValdez requested a review from a team as a code owner September 23, 2024 08:30
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

Just a minor nitpick, can you format the lines to fit the 80/88 character limit?

@ankith26
Copy link
Member

While building the html docs (with py -m buildconfig docs) I am getting the following warnings:

/[my_path]/pygame-ce/docs/reST/ref/window.rst:49: ERROR: Unexpected indentation.
/[my_path]/pygame-ce/docs/reST/ref/window.rst:65: ERROR: Unexpected indentation.

The .. code-block:: python part must not be indented relative to the text, and the python code should be intended only once. Also I believe there should be one empty line before according to the rst spec.

@yunline yunline added docs window pygame.Window labels Sep 25, 2024
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! 🎉

Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for contributing!

@zoldalma999 zoldalma999 merged commit f554e77 into pygame-community:main Sep 27, 2024
@zoldalma999 zoldalma999 added this to the 2.5.2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs window pygame.Window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants