Skip to content

Conversation

@hisa10
Copy link
Contributor

@hisa10 hisa10 commented Sep 23, 2024

Added Japanese version of README, also added links to zh-tw to avoid conflict with commit from @noahcse

@hisa10 hisa10 requested a review from a team as a code owner September 23, 2024 08:24
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Japanese but @ maya on discord has given this a read.

Thanks for contributing! 🎉 though we should probably merge the other PR first because there's definitely going to be merge conflicts for one of you both to fix :)

Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as ankith said :

I don't know Japanese but @ maya on discord has given this a read.

Thanks for contributing! 🎉 :)

Like we did for french and other translations, we can always wait for japanese people to open an issue concerning this!

@bilhox bilhox merged commit c1cadfd into pygame-community:main Sep 24, 2024
@ankith26 ankith26 added this to the 2.5.2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants