Skip to content

Conversation

@Matiiss
Copy link
Member

@Matiiss Matiiss commented Jul 5, 2024

No description provided.

@Matiiss Matiiss requested a review from a team as a code owner July 5, 2024 19:20
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@oddbookworm oddbookworm added docs Surface pygame.Surface labels Jul 5, 2024
@ankith26 ankith26 added this to the 2.5.1 milestone Jul 5, 2024
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can make space for this change, LGTM and thanks lol

@ankith26 ankith26 changed the title Update surface.rst Fix premul_alpha_ip doc indentation issue Jul 5, 2024
@bilhox
Copy link
Contributor

bilhox commented Jul 5, 2024

I just noticed that the new attributes of Surface were placed at the end of the docs, they should be at the beginning just like other docs pages. Since you're "updating surface.rst" (name updated by ankith), it might be interesting to change it, so people use properties rather than getters.

@Starbuck5
Copy link
Member

I just noticed that the new attributes of Surface were placed at the end of the docs, they should be at the beginning just like other docs pages. Since you're "updating surface.rst" (name updated by ankith), it might be interesting to change it, so people use properties rather than getters.

Regardless of whether this a problem or not, it should be a separate issue/PR, this one is small and focused already. Also some other docs pages don't show the properties in the list at all (Rect).

@ankith26
Copy link
Member

ankith26 commented Jul 6, 2024

agree with starbuck, so that this PR can be merged in now

@ankith26 ankith26 merged commit ec76793 into pygame-community:main Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Surface pygame.Surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants