-
-
Notifications
You must be signed in to change notification settings - Fork 185
Centralize CI config and make it more uniform (Adds macOS arm64 pypy CI) #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
297d723
to
a91e0db
Compare
While doing this PR I also happened to
Here is a table of cumulated-time comparisons, along with per config notes
|
a91e0db
to
bb792ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Ankith.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The goal of this PR is to centralize all common cibuildwheel config, and make our CI more uniform.
We currently take different strategies on different workflows. manylinux takes the "build for all pythons in one workflow per arch" strategy. Mac takes an (ever so slightly harder to maintain) strategy of handwritten "split jobs evenly" while windows takes the "every run on its own" thing.
I figured that the strategy manylinux takes is actually the most efficient, even if it's slower than the rest. Why?
pyproject.toml
Also switches build backend to
build[uv]
which should again save some CI time.I may also explore more in the caching area in future PRs and see how that improves things.