Skip to content

Docs generation is now python -m buildconfig docs and python -m buildconfig docs full_generation #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

oddbookworm
Copy link
Member

I didn't want to have to invoke a specific python file every time I generate docs, so here's a useful helper

Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running it from setup.py it says Please use the following replacement: D:\Programs\Python312\python.exe buildconfig docs full_generation but running that command raises ImportError: attempted relative import with no known parent package as the suggestion is missing '-m'. Other than that, I like this helper

@oddbookworm
Copy link
Member Author

When running it from setup.py it says Please use the following replacement: D:\Programs\Python312\python.exe buildconfig docs full_generation but running that command raises ImportError: attempted relative import with no known parent package as the suggestion is missing '-m'. Other than that, I like this helper

Oops, it's fixed now

Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also found it a bit annoying before

Co-authored-by: Ankith <itsankith26@gmail.com>
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

PS: the fails seem unrelated so I will merge this PR in now

@ankith26 ankith26 added this to the 2.5.1 milestone Jun 30, 2024
@ankith26 ankith26 merged commit db03934 into pygame-community:main Jun 30, 2024
36 of 38 checks passed
gresm pushed a commit to gresm/pygame-ce that referenced this pull request Jul 16, 2024
…ildconfig docs full_generation` (pygame-community#2942)

* Can now use python -m buildconfig docs full_generation to generate docs instead of calling make_docs.py directly

* Fixed buildconfig command to be a module run

* Updated docs readme to point to new command

* Stricter command interface (thanks Ankith)

Co-authored-by: Ankith <itsankith26@gmail.com>

---------

Co-authored-by: Ankith <itsankith26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants