Skip to content

Convert meson options from .txt to .options #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Convert meson options from .txt to .options #2937

wants to merge 1 commit into from

Conversation

andrewhong04
Copy link
Member

Click here for more info regarding .options: https://mesonbuild.com/Build-options.html

@andrewhong04 andrewhong04 requested a review from a team as a code owner June 18, 2024 17:34
ankith26
ankith26 requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR may have to wait... it is failing our debian multiarch CI which uses system meson (that isn't on a new enough version)

@ankith26
Copy link
Member

Alternatively you could make the runner use pip provided meson instead of the apt provided one

@yunline yunline added build Compiling stuff meson Meson build system labels Jun 24, 2024
@ankith26 ankith26 marked this pull request as draft June 28, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
build Compiling stuff meson Meson build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewhong04 @ankith26 @yunline