Fix scaled-after-non-scaled usage #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldalma999
reviewed
Jun 14, 2024
zoldalma999
approved these changes
Jun 14, 2024
ankith26
force-pushed
the
ankith26-display-setmode
branch
2 times, most recently
from
114ca2d to
22d5656
Compare
|
A bit of interesting history: these new API functions were basically added for us by the SDL folks in response to issue #2190 so we have to make use of it! |
Starbuck5
reviewed
Jun 18, 2024
ankith26
force-pushed
the
ankith26-display-setmode
branch
from
22d5656 to
1434bd4
Compare
|
It doesn't fix #2376 as of now, but SDL has patched the underlying issue and the fix should be available in the next SDL bump, so let this PR wait for that |
ankith26
force-pushed
the
ankith26-display-setmode
branch
from
1084774 to
61ed0ec
Compare
|
After the latest rebase, this PR should fix the issue on mac as well. |
|
Tested on my Mac (reminder it's a 2015 Intel based MacBook Pro) and yes indeed the tests were successful with the latest PR, thanks! |
damusss
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #2737 and fixes #2376 (they are essentially the same issue).
Note that I couldn't reproduce the original issue on Ubuntu, however @zoldalma999 has tested this branch and reported that this fix has worked on windows. Would be nice if someone gave this a test on a mac as well.
Also worth mentioning that the fix only works for SDL 2.28.0+, but all the wheels we distribute are on 2.30.3 so this shouldn't be a big deal.
It was also mentioned in one of the linked issues that #2571 is also the same issue, but I don't think that's the case.