Skip to content

Update transform.get/set_smoothscale_backend typehint from str to Literal #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

damusss
Copy link
Member

@damusss damusss commented Jun 9, 2024

It's like this for other functions (for example the ones requiring an image format) and since the valid options are just a few it makes sense to be clear in the typehint about them, so one can skip going to the docs.
I omitted the deprecated ones, as other stubs do that too.

@damusss damusss requested a review from a team as a code owner June 9, 2024 19:24
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yunline yunline added the type hints Type hint checking related tasks label Jun 11, 2024
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 merged commit d1ca090 into pygame-community:main Jun 11, 2024
36 checks passed
@damusss damusss deleted the setsmoothscalebackend-typehint branch June 11, 2024 07:47
@ankith26 ankith26 added this to the 2.5.1 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type hints Type hint checking related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants