Skip to content

Fixed missing comma in README #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fixed missing comma in README #2907

merged 2 commits into from
Jun 3, 2024

Conversation

REX2626
Copy link
Contributor

@REX2626 REX2626 commented Jun 3, 2024

Fixes #2870

@REX2626 REX2626 requested a review from a team as a code owner June 3, 2024 15:34
oddbookworm
oddbookworm approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🥳, this looks good to me

ankith26
ankith26 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing to pygame-ce! 😎

PS: we are on a merge freeze for the 2.5.0 release, so when this PR is merged onto main it will get released in the upcoming 2.5.1 release

@ankith26 ankith26 added this to the 2.5.1 milestone Jun 3, 2024
ankith26
ankith26 requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I now noticed that the same issue exists on the different translations of the README (the files are in docs/readmes). Could you apply the same fix on all the files?

@REX2626
Copy link
Contributor Author

REX2626 commented Jun 3, 2024

It should be fixed on all the README translations now.

ankith26
ankith26 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates LGTM

@ankith26 ankith26 merged commit 3c14cd1 into pygame-community:main Jun 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Grammar: Missing comma in main Readme?
3 participants
@REX2626 @ankith26 @oddbookworm