Try re-enabling tests disabled since SDL 2.0.18 #2885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
May 29, 2024
ankith26
reviewed
May 30, 2024
ankith26
approved these changes
May 30, 2024
zoldalma999
approved these changes
Jun 19, 2024
gresm
pushed a commit
to gresm/pygame-ce
that referenced
this pull request
Jul 16, 2024
* Try re-enabling tests disabled since SDL 2.0.18 fixes pygame-community#1492 * Disable get_focused test on non Windows/macOS platforms * Disable get_focused test on non Windows/macOS platforms * change platform.platform() to platform.system()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1492
These tests work locally on Windows now which seems to have been the main trigger for them being disabled. We'll see if the key test works on the CI.
EDIT: Hooray, I vote we try re-enabling all of these - but keep an eye on that key_test one as it also runs on CI unlike the event test which is local one only.