Skip to content

Added shim to fix portmidi break #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2024
Merged

Added shim to fix portmidi break #2863

merged 2 commits into from
May 24, 2024

Conversation

oddbookworm
Copy link
Member

Portmidi broke due to a signature change, and it manifested recently with the 2.0.4 release being installed on my sytem. This shim fixes the cython so that we don't get a compiler error when building with newer portmidi

@oddbookworm oddbookworm requested a review from a team as a code owner May 20, 2024 20:32
@oddbookworm oddbookworm mentioned this pull request May 20, 2024
Closed
@Starbuck5 Starbuck5 mentioned this pull request May 20, 2024
Open
ankith26
ankith26 reviewed May 21, 2024
View reviewed changes
ankith26
ankith26 reviewed May 21, 2024
View reviewed changes
@ankith26 ankith26 linked an issue May 21, 2024 that may be closed by this pull request
Portmidi broke cython #2864
Closed
@ankith26 ankith26 added this to the 2.5.0 milestone May 24, 2024
MyreMylar
MyreMylar approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 1aa950b into pygame-community:main May 24, 2024
37 checks passed
oddbookworm added a commit to oddbookworm/pygame-ce that referenced this pull request Jul 8, 2024
@oddbookworm
Revert "Merge pull request pygame-community#2863 from oddbookworm/fix…
0f29533 
…-portmidi-compile-issue"

This reverts commit 1aa950b, reversing
changes made to 0d1e826.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 left review comments

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
cython dependencies midi pygame.midi
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Portmidi broke cython
4 participants
@oddbookworm @MyreMylar @Starbuck5 @ankith26