Add clarifications about ranges in mixer docs
#2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify mixer docs
ankith26
reviewed
Mar 6, 2024
|
I disagree that the "0.0 -1.0" range needs clarification for volume. |
MyreMylar
reviewed
May 23, 2024
ankith26
approved these changes
May 25, 2024
ankith26
changed the title
mixer docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think mixer module docs need some clarification.
A value from 0 to the value of get_num_channels()is for [0-num_channels), whilethe value argument is between 0.0 and 1.0,volume in the range of 0.0 to 1.0 (inclusive)anda value from 0.0 to 1.0 representing the volumemean [0.0-1.0].Should it be "from x to y (inclusive/exclusive)" everywhere?