Skip to content

Added more / (positional-only notation) #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2024
Merged

Added more / (positional-only notation) #2691

merged 1 commit into from
Jan 27, 2024

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Jan 23, 2024

Mostly affected pygame.geometry

@Matiiss Matiiss requested a review from a team as a code owner January 23, 2024 00:23
@Matiiss
Added more / (positional-only notation)
64809d7 
Mostly affected `pygame.geometry`

regen docs
@Matiiss Matiiss force-pushed the matiiss-positional-only-notation-2 branch from 1e47d53 to 64809d7 Compare January 23, 2024 00:32
ankith26
ankith26 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

itzpr3d4t0r
itzpr3d4t0r approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@itzpr3d4t0r itzpr3d4t0r merged commit b91623b into pygame-community:main Jan 27, 2024
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Jan 28, 2024
@Starbuck5 Starbuck5 added docs type hints Type hint checking related tasks labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@itzpr3d4t0r itzpr3d4t0r itzpr3d4t0r approved these changes

Assignees
No one assigned
Labels
docs type hints Type hint checking related tasks
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Matiiss @ankith26 @itzpr3d4t0r @Starbuck5