General example changes #2581

bilhox · 2023-11-20T21:43:14Z

Hi, I took a look at all examples, and made some fixes.

aacircle.py :

Removed the pretty weird try block and replaced it by a beautiful while loop

aliens.py :

renamed all to all_sprite, because all is a native python function.
removed depth argument
added pygame.SCALED because on Windows, there is a problem with FULLSCREEN mode

chimp.py :

removed RenderPlainbecause it's deprecated
renamed some variables so it follows python naming convention

dropevent.py :

renamed some variables because either it doesn't follow the python naming convention, or it is not intuitive

playmus.py :

This is a proposition from Matiiss, switching from pygame.freetype to pygame.Font
Revamped the code, as its structure isn't understandable for a beginner.

~~resizing_new.py~~:

~~renamed a variable because it's not intuitive~~
Removal plan is being discussed

scaletest.py :

removed useless alias
renamed some variables/functions because either it doesn't follow the python naming convention, or it is not intuitive

liquid.py :

renamed some variables/functions because either it doesn't follow the python naming convention, or it is not intuitive
remove time.sleep so it uses pygame.Clock

bilhox · 2023-11-20T21:50:07Z

This should fix #2518

examples/aacircle.py

examples/chimp.py

examples/dropevent.py

examples/playmus.py

examples/aacircle.py

examples/aliens.py

examples/playmus.py

This reverts commit d5897be.

This reverts commit 5ed783e.

pygame-community#2581

MyreMylar

LGTM 👍

examples/aliens.py

ankith26

This PR needs a lint run to make CI happy

examples/resizing_new.py

examples/scaletest.py

…ygame-ce into general_example_changes

ankith26

I had already tested all these examples in the last reviewing round that I did. The code changes LGTM.
I will go ahead and merge this in now, though there is always scope for further improvements in future (in hopefully smaller and more focussed PRs).

Thanks for contributing! 🎉

* scaletest.py fixes * example fixes * format fix * format fixes * liquid example fix * format fic * removed time import * fix 1 * update example * droid problem fixes * alien example update * chimp example * removed durk from buildconfig * Revert "removed durk from buildconfig" This reverts commit d5897be. * Revert "chimp example" This reverts commit 5ed783e. * chimp tutorial update * format fix * playmus fix * Further aliens.py cleanups * Further scaletest.py cleanups * Update examples/aliens.py * formatting * scaletest fix using irl key access * clock scaletest * revert changes resizing_new --------- Co-authored-by: Dan Lawrence <danintheshed@gmail.com>

bilhox and others added 3 commits November 19, 2023 17:50

scaletest.py fixes

6d21d67

Merge branch 'pygame-community:main' into general_example_changes

fe00c24

example fixes

798e0b3

bilhox requested a review from a team as a code owner November 20, 2023 21:43

bilhox added 2 commits November 20, 2023 22:48

format fix

f579e1e

format fixes

b17033a

yunline added the examples label Nov 21, 2023

bilhox added 3 commits November 21, 2023 13:21

liquid example fix

7291357

format fic

1b8c12f

removed time import

877ffcc