Skip to content

Bump cython to 3.0.0 #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2023
Merged

Bump cython to 3.0.0 #2395

merged 4 commits into from
Aug 27, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Aug 14, 2023

No description provided.

@yunline yunline requested a review from a team as a code owner August 14, 2023 04:43
@yunline yunline mentioned this pull request Aug 14, 2023
Closed
4 tasks
ankith26
ankith26 reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of getting on cython 3.0.0
I can't remember at this point, what happened to that one PR that was trying to get cython files generated as part of our build step?

@MyreMylar
Copy link
Member

I like the idea of getting on cython 3.0.0 I can't remember at this point, what happened to that one PR that was trying to get cython files generated as part of our build step?

It is here #1877

pmp-p
pmp-p approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@pmp-p pmp-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also fixes cython3+emsdk latest wasm multiple compile errors for me

@Starbuck5
Copy link
Member

Why not add __reduce__ to the stubs instead of turning off pickling?

@yunline
Copy link
Contributor Author

yunline commented Aug 21, 2023

Why not add __reduce__ to the stubs instead of turning off pickling?

Classes like Renderer was unable to be picled ever before. And I believe few users need to pickle those objects.
So I think turning off pickling can be a better way than adding something that may mess up the stubs.

dr0id
dr0id approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works...

LGTM

@Starbuck5
Copy link
Member

Classes like Renderer was unable to be picled ever before. And I believe few users need to pickle those objects.
So I think turning off pickling can be a better way than adding something that may mess up the stubs.

It's not messing up the stubs to update them with a new method being created.

But it's okay good for now, you're right.

Starbuck5
Starbuck5 approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Starbuck5 Starbuck5 added this to the 2.3.2 milestone Aug 27, 2023
@Starbuck5 Starbuck5 merged commit 9127958 into pygame-community:main Aug 27, 2023
ankith26 pushed a commit that referenced this pull request Sep 2, 2023
@Starbuck5 @ankith26
Merge pull request #2395 from yunline/cython3
10179e2 
Bump cython to 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 left review comments

@dr0id dr0id dr0id approved these changes

@pmp-p pmp-p pmp-p approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@yunline @MyreMylar @Starbuck5 @dr0id @pmp-p @ankith26