Skip to content

documentation: fix header underline in joystick.rst #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

documentation: fix header underline in joystick.rst #2365

wants to merge 1 commit into from

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented Jul 31, 2023

Fix warning while generating docs.

...\docs\reST\ref\joystick.rst:442: WARNING: Title underline too short.

Nintendo Switch Left/Right Joy-Con (pygame **2.3.0** / after SDL **2.24.0**)
*********************************************************************
...\docs\reST\ref\joystick.rst:442: WARNING: Title underline too short.

Nintendo Switch Left/Right Joy-Con (pygame **2.3.0** / after SDL **2.24.0**)
*********************************************************************

@dr0id dr0id requested a review from a team as a code owner July 31, 2023 08:51
yunline
yunline approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yunline yunline added the docs label Jul 31, 2023
@bilhox
Copy link
Contributor

bilhox commented Jul 31, 2023

Hello,

I fixed it in my PR that removes in parrallel two methods to pygame.Joystick.

@dr0id
Copy link
Contributor Author

dr0id commented Jul 31, 2023

Hello,

I fixed it in my PR that removes in parrallel two methods to pygame.Joystick.

I'll review it. Is it #2363 ?

@bilhox
Copy link
Contributor

bilhox commented Jul 31, 2023

yes

@dr0id
Copy link
Contributor Author

dr0id commented Jul 31, 2023

Closing this PR since it will be fixed in #2363

@dr0id dr0id closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunline yunline yunline approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr0id @bilhox @yunline