Fix FRect slice subscripting #2313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-rect-impl-fixes
branch
from
abb3bab to
6439bae
Compare
Starbuck5
approved these changes
Jul 15, 2023
Member
Starbuck5
left a comment
Starbuck5
left a comment
There was a problem hiding this comment.
Thanks!
That definitely is a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to fix a minor issue in
FRectthat I happened to notice.Slicing an
FRectshould give floats in the list returned, not truncated integers. I'm assuming this was just a mistake, if it was a conscious decision feel free to correct me