Skip to content

Multiline examples #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 18, 2023
Merged

Conversation

JiffyRob
Copy link
Contributor

@JiffyRob JiffyRob commented Jun 8, 2023

This contains a commit for every example listed and not covered in issue #2206 except for playmus. The default wrapping behaviour may not be desired for dropevent though:
image
I tried not to change too much but the joystick example got the TextPrint class removed and the music fade example's constants and globals were put to the top (because I just could not wrap my head around the code else). The font viewer is also left aligned now because multiline rendering does not center text. I'm open to change this if necessary.

@JiffyRob JiffyRob requested a review from a team as a code owner June 8, 2023 02:15
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for working through this.

I'd like someone with joystick hardware to review the joystick example, if possible. I can't really test it in action because I don't have any joysticsks.

@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jun 29, 2023
@JiffyRob
Copy link
Contributor Author

I did test it with a USB gamepad and AFAIK it did everything properly. That said, I can't give a screenshot and a maintainer ought to test it anyway

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but like Starbuck5, I can't test it myself. I'm not merging it because someone else should test it first

@ankith26 ankith26 requested a review from zoldalma999 July 5, 2023 16:21
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the joystick example, and left some notes.

Also, you can set font.align to be centered for the dropevent example, I think that way it does look better.

@Starbuck5
Copy link
Member

It seems like the joystick example notes have been resolved, so I'm going to go ahead and merge. Thanks for working on this JiffyRob!

@Starbuck5 Starbuck5 merged commit c41f75a into pygame-community:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants