-
-
Notifications
You must be signed in to change notification settings - Fork 185
Multiline examples #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline examples #2235
Conversation
…or multiline text not centering nicely
…s now gone and constants put at the top of the file
…intuitive results" This reverts commit 8eeefd9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for working through this.
I'd like someone with joystick hardware to review the joystick example, if possible. I can't really test it in action because I don't have any joysticsks.
I did test it with a USB gamepad and AFAIK it did everything properly. That said, I can't give a screenshot and a maintainer ought to test it anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but like Starbuck5, I can't test it myself. I'm not merging it because someone else should test it first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the joystick example, and left some notes.
Also, you can set font.align to be centered for the dropevent example, I think that way it does look better.
It seems like the joystick example notes have been resolved, so I'm going to go ahead and merge. Thanks for working on this JiffyRob! |
This contains a commit for every example listed and not covered in issue #2206 except for playmus. The default wrapping behaviour may not be desired for dropevent though:

I tried not to change too much but the joystick example got the TextPrint class removed and the music fade example's constants and globals were put to the top (because I just could not wrap my head around the code else). The font viewer is also left aligned now because multiline rendering does not center text. I'm open to change this if necessary.