Skip to content

Fix the default value of title argument in video.Window #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2023
Merged

Fix the default value of title argument in video.Window #2200

merged 1 commit into from
May 28, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented May 27, 2023 •
edited
Loading

Issue: #2199
Fixes #2199

@yunline yunline requested a review from a team as a code owner May 27, 2023 07:43
@Starbuck5
Copy link
Member

If you say in the comment as

"
fixes #2199
"

it will auto link this PR to close that issue when merged

@Starbuck5 Starbuck5 added type hints Type hint checking related tasks _sdl2 pygame._sdl2 labels May 27, 2023
@Starbuck5 Starbuck5 added this to the 2.3 milestone May 27, 2023
Temmie3754
Temmie3754 approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@Temmie3754 Temmie3754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed this fixes the issue 👍

@Temmie3754 Temmie3754 merged commit c4095e6 into pygame-community:main May 28, 2023
@yunline yunline deleted the video-window-title-stub branch May 28, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@Temmie3754 Temmie3754 Temmie3754 approved these changes

Assignees
No one assigned
Labels
_sdl2 pygame._sdl2 type hints Type hint checking related tasks
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Default title of video.Window is sill "pygame" in stub
3 participants
@yunline @Starbuck5 @Temmie3754