-
-
Notifications
You must be signed in to change notification settings - Fork 216
Reveal .. note:: reST block background color again
#2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reveal .. note:: reST block background color again
#2163
Conversation
.. note:: reST block background color again
|
This increases the amount of emphasis the notes get, which is interesting. It's good in some cases, but I feel in other cases the previous content is now emphasized too much. So they should be changed away "notes" in that case. Some candidates that might not want to be notes after this PR: |
|
This also will have implications for #2122. Since I believe this PR will be merged before that one, that will need to be rebased and updated to support these changes. Heads up @Notenlish |
MyreMylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this looks in general. I think we can handle demoting blocks from being attention grabbing notes in other PRs over time.
0edc96f to
d86ebd4
Compare
The initial change was made while doing docs style improvements, however it is ultimately more beneficial and widespread to make '.. note::' reST blocks stand out.
e96c12b to
3989d24
Compare
3989d24 to
28ef841
Compare
zoldalma999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!



The initial change was made while doing docs style improvements, however it is ultimately more beneficial and widespread to have
.. note::reST blocks stand out. It makes them harder to overlook, thus making it less likely for users to miss important details.Before
After