-
-
Notifications
You must be signed in to change notification settings - Fork 185
_sdl2.video
docs rewrite, minor reorderings & method signature changes
#2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1daa46e
to
99b1862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for this!
_sdl2.video
docs rewrite, minor method signature changes_sdl2.video
docs rewrite, code reordering, minor method signature changes
_sdl2.video
docs rewrite, code reordering, minor method signature changes_sdl2.video
docs rewrite, minor method signature changes
_sdl2.video
docs rewrite, minor method signature changes_sdl2.video
docs rewrite, minor reorderings & method signature changes
64469b9
to
5d19055
Compare
93a0a8f
to
70984f3
Compare
Alright, I took another good look at the changes made in this PR, and took some time to address all the complaints. Should have done that earlier, but I think it the PR should be ready now. |
818ae99
to
d94ecfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (apart from that minor thing that's out of the scope of this PR)
EDIT: that minor thing is also now fixed 👍
This has the approvals to merge, but the cython should be regenerated to sync the default window title change. And to be sure that's safe the branch should be rebased against main to not wipe out any existing cython changes since the inception of this branch. Also the commit history of the branch is a lot at this point, it could "squash and merge"d or Mega could squash down some commits into each other. |
e4436dc
to
2551b7f
Compare
All done and completed, Squash and Merge sounds good, now I have to figure out why CI is failing -_- Edit: Seems like recompilation with Python 3.11 was needed, CI is happy now. |
2551b7f
to
3cf6028
Compare
3cf6028
to
b1b98f1
Compare
3493b92
to
2f75a05
Compare
Since Cython is a code generator, the only relevant thing is the version of Cython. I didn't like how the Cython version changed in your regen, and how every file was regenerated (even ones that shouldn't have any change), so I changed the Cython regen commit a bit. But now if I squash and merge we'll both be equal authors on this PR, from a commit perspective. Which isn't accurate. I'd like you to squash the first 14 commits into 1 or several commits authored exclusively by you, then we can do a normal merge. |
a0ce59c
to
ef35a86
Compare
…tures to snake case for _sdl2.video
ef35a86
to
9b8c23e
Compare
Alright, commits have now been squashed down to 2. |
(based on #2092)
This commit effectively rewrites all the documentation of the
pygame._sdl2.video
module, by either adding new information for undocumented content, or extracting information from existing docstrings in the codebase. Along with the documentation changes, some function signatures were modified to adhere to the snake case naming convention described in PEP 8.