-
-
Notifications
You must be signed in to change notification settings - Fork 185
Add .point_size
attribute modifier for fonts
#1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd like to put this in 2.1.4, because it is font related - if you can get it working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my testing 👍 Nice work and thanks for fixing it up.
I have some style and philosophical(?) quibbles that you may, or may not, agree with so I'm leaving this review on comment for now.
I believe we should call this “size” to match the existing freetype attribute. |
@Starbuck5 and I were in call and realized that |
.point_size
attribute modifier for fonts
Whoops, I've been in hiatus for a while. I've pushed some commits resolving some reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I've noticed this raises a deprecation warning if you give it a float, and the SDL_TTF_VERSION_ATLEAST could be relaxed around getters. But that can be fixed in the future.
Original PR: pygame/pygame#3688
This pull request has been significantly improved since its original state.
Video
Test code