Surface, Draw, and Transform segfault fixes #1940
Conversation
|
This is a reopening of pygame/pygame#3680 with additions from pygame/pygame#3525 |
src_c/surface.c
Outdated
| SDL_Surface *surf = pgSurface_AsSurface(self); | ||
| SURF_INIT_CHECK(surf) | ||
|
|
||
| SDL_Surface *src, *dest = pgSurface_AsSurface(self); |
There was a problem hiding this comment.
why are we getting self as an SDL_Surface twice here? Think we could just add the check on src or dest after the existing call to pgSurface_AsSurface() (since they are pointing to the same thing here).
src_c/surface.c
Outdated
| if (!dest || !src) | ||
| return RAISE(pgExc_SDLError, "display Surface quit"); | ||
| if (!dest) { | ||
| SURF_INIT_CHECK(src) | ||
| } |
There was a problem hiding this comment.
this check is different now. Previously it would error if either src or dest were null, now it will only error if both src and dest are null.
src_c/surface.c
Outdated
| SDL_Surface *surf = pgSurface_AsSurface(self); | ||
| SURF_INIT_CHECK(surf) | ||
|
|
||
| SDL_Surface *src, *dest = pgSurface_AsSurface(self); |
There was a problem hiding this comment.
Similar issue as above. The check here could just be moved below the existing call to pgSurface_AsSurface()
MyreMylar
left a comment
MyreMylar
left a comment
There was a problem hiding this comment.
Overall looks good 👍
Just a couple of spots that should be fixed. 🔨
3 participants
fixes a whole bunch o' segfaults related to surface, draw, and transform