Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality of FaceToEdge transform to work for 3D tetrahedral mesh elements #9776

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

Aiik
Copy link
Contributor

@Aiik Aiik commented Nov 12, 2024

Now transforms 2D triangular elements/faces with shape [3,n] to as well as 3D tetrahedral elements with shape [4,n] to edges of shape [2,n].

Including pytest case for face input with shape [4,n]

…hedral mesh elements.

Included pytest case for face input with shape [4,n]
@Aiik Aiik requested a review from wsad1 as a code owner November 12, 2024 10:03
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@rusty1s rusty1s changed the title Added functionality of transform/face_to_edge.py to work for 3D tetrahedral mesh elements Added functionality of FaceToEdge transform to work for 3D tetrahedral mesh elements Nov 13, 2024
@rusty1s rusty1s merged commit 60acb38 into pyg-team:master Nov 13, 2024
18 of 19 checks passed
mattjhayes3 pushed a commit to mattjhayes3/pytorch_geometric that referenced this pull request Dec 14, 2024
…ral mesh elements (pyg-team#9776)

Now transforms 2D triangular elements/faces with shape [3,n] to as well
as 3D tetrahedral elements with shape [4,n] to edges of shape [2,n].

Including pytest case for face input with shape [4,n]

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants