Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNN+LLM example (part 1) #9350

Merged
merged 463 commits into from
May 22, 2024
Merged

GNN+LLM example (part 1) #9350

merged 463 commits into from
May 22, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented May 22, 2024

Splits #9167 into multiple PRs.

puririshi98 and others added 30 commits March 13, 2024 17:16
…ince they are unreasonable and exist since the linter thinks all atributes of a graph can either be a value or None
…ince they are unreasonable and exist since the linter thinks all atributes of a graph can either be a value or None
…ince they are unreasonable and exist since the linter thinks all atributes of a graph can either be a value or None
puririshi98 and others added 10 commits May 7, 2024 15:55
/usr/local/lib/python3.10/dist-packages/torch_geometric/datasets/web_qsp_dataset.py:237: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.
The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.

For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.


  nodes.node_attr.fillna("", inplace=True)
@github-actions github-actions bot removed the dataset label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 16.19718% with 238 lines in your changes are missing coverage. Please review.

Project coverage is 86.34%. Comparing base (61c47ee) to head (a7f072a).
Report is 8 commits behind head on master.

Current head a7f072a differs from pull request most recent head 2fbc021

Please upload reports for the commit 2fbc021 to get more accurate results.

Files Patch % Lines
torch_geometric/nn/models/g_retriever.py 11.76% 105 Missing ⚠️
torch_geometric/nn/text/llm.py 16.52% 101 Missing ⚠️
...eometric/nn/text/sentence_transformer_embedding.py 20.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9350      +/-   ##
==========================================
- Coverage   87.33%   86.34%   -1.00%     
==========================================
  Files         460      475      +15     
  Lines       30385    31006     +621     
==========================================
+ Hits        26536    26771     +235     
- Misses       3849     4235     +386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 9dc2302 into master May 22, 2024
16 checks passed
@rusty1s rusty1s deleted the gnn_llm2 branch May 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants